x-pack/filebeat/input/entityanalytics/provider/okta: collect enrolled devices for users#49813
Conversation
🤖 GitHub commentsJust comment with:
|
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds an optional 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsTimed out fetching pipeline failures after 30000ms Comment |
| The metadata to enrich users with. This is an array of values that may contain "groups", "roles" and "factors", or "none". If the array only contains "none", no metadata is collected for users. The default behavior is to collect "groups". | ||
| The metadata to enrich users with. This is an array of values that may contain "groups", "roles", "factors" and "enrolled_devices", or "none". If the array only contains "none", no metadata is collected for users. The default behavior is to collect "groups". | ||
|
|
||
| When "enrolled_devices" is included, each user is enriched with the list of devices enrolled for that user by calling the [List User Devices](https://developer.okta.com/docs/api/openapi/okta-management/management/tags/userresources/other/listuserdevices) API. This requires one additional API request per user, so it is disabled by default to avoid hitting Okta rate limits. |
There was a problem hiding this comment.
I think this Vale rule is an example of over-extension of the WCAG concerns and is related to elastic/vale-rules#116.
The rules above are another instance of #49805 (comment).
cc @theletterf
| // EnrichWith specifies the additional data that | ||
| // will be used to enrich user data. It can include | ||
| // "groups", "roles" and "factors". | ||
| // "groups", "roles", "factors" and "enrolled_devices". |
There was a problem hiding this comment.
Why is this "enrolled_devices" rather than just "devices".
There was a problem hiding this comment.
Because for the same provider we already have a dataset called devices, and a setting called collect_device_details, so calling it just devices as well made me think it could cause confusion.
Proposed commit message
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Related issues